Skip to content

nix/ci: add and enable llvm-17 #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

nix/ci: add and enable llvm-17 #534

wants to merge 2 commits into from

Conversation

JakeHillion
Copy link
Contributor

No description provided.

@JakeHillion JakeHillion force-pushed the llvm-17 branch 4 times, most recently from 9c5ec2c to 58ecb4e Compare July 22, 2025 13:53
tyroguru
tyroguru approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@tyroguru tyroguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it but we have some red on a couple of CI checks. Land it if you are happy with them.

@JakeHillion JakeHillion force-pushed the llvm-17 branch 2 times, most recently from baaf387 to 3fc72bf Compare July 29, 2025 11:01
@JakeHillion
Copy link
Contributor Author

Still working on this, need to figure out which failures are for all future revisions and which are for LLVM-17 only. These timeouts in particular seem like an LLVM-17 bug. Will see what 18 does and if they're fine on 18 will skip the tests for 17.

@JakeHillion
tests: add support for dynamically skipping tests based on llvm version
cc35384 
Some tests are useful but are either broken on individual LLVM versions
or before/after an LLVM version. Add new options to the test TOML that
let us skip tests dynamically based on too old/too new/explicitly
skipped LLVM major versions.

Test plan:
- CI
- Used in stacked PRs
@JakeHillion
nix/ci: add and enable llvm-17
10bd56d
@JakeHillion
Copy link
Contributor Author

Most of the issues are weird DWARF (old drgn issues mentioned elsewhere) and strange timeouts/linking things. All fine to skip, even though it's not ideal.

The remaining test failure that seems legitimate is OidIntegration.cycles_raw_ptr.

This can be reproduced with JIT logging with: build/test/integration/integration_test_runner --gtest_filter='OidIntegration.cycles_raw_ptr' -P --enable-feature jit-logging. The generated code looks totally fine to my eye and should be following the raw pointers. But the JIT log disagrees:

I20250804 14:25:20.697924 140167335514880 OIDebugger.cpp:267] Outputting JIT logs:
I20250804 14:25:20.697933 140167335514880 OIDebugger.cpp:270] JITLOG: RawNode @00007ffd84314300
I20250804 14:25:20.697937 140167335514880 OIDebugger.cpp:270] JITLOG: value_0 @00007ffd84314300
I20250804 14:25:20.697940 140167335514880 OIDebugger.cpp:270] JITLOG: obj @00007ffd84314300
I20250804 14:25:20.697943 140167335514880 OIDebugger.cpp:270] JITLOG: next_2 @00007ffd84314308
I20250804 14:25:20.697946 140167335514880 OIDebugger.cpp:270] JITLOG: ptr val @0000000000000000
I20250804 14:25:20.697950 140167335514880 OIDebugger.cpp:276] Finished outputting JIT logs.

And treebuilder generates as if there are no next entries, causing the test to fail. Need to spend a bit more time looking at this specific one, I don't know how LLVM-17 could have caused it to fail - maybe the pointer tracking broke?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyroguru tyroguru tyroguru approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeHillion @tyroguru @facebook-github-bot